Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nlu format return #624

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix: nlu format return #624

merged 2 commits into from
Jan 24, 2025
+5 −2

Conversation

marrouchi
Copy link
Contributor

@marrouchi marrouchi commented Jan 23, 2025 •
edited
Loading

Motivation

Make sure that the return type of the format() method in any NLU helper is generic.

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marrouchi marrouchi marked this pull request as ready for review January 23, 2025 16:17
@marrouchi marrouchi merged commit fe5420e into main Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedAliBouhaouala MohamedAliBouhaouala MohamedAliBouhaouala left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marrouchi @MohamedAliBouhaouala